refactor(Support): rewrite class component to functional#8173
Open
sujalgoel wants to merge 2 commits intowebpack:mainfrom
Open
refactor(Support): rewrite class component to functional#8173sujalgoel wants to merge 2 commits intowebpack:mainfrom
sujalgoel wants to merge 2 commits intowebpack:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
4 tasks
| <h2> | ||
| Backers | ||
| </h2> | ||
| `; |
Member
There was a problem hiding this comment.
Can we add more tests and handle more cases, including, image not loaded and other stuff
…d missing rank/type cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #8161. Converts Support from a class component to a functional component using hooks. Moves the supporters computation into
useMemoto satisfy thereact-hooks/puritylint rule. Also adds tests.What kind of change does this PR introduce?
Refactor. No behavior or visual changes.
Did you add tests for your changes?
Does this PR introduce a breaking change?
No.
If relevant, what needs to be documented once your changes are merged or what have you already documented?
N/A
Use of AI
No.