Add a defaultValue fallback for theme#4
Open
mergebandit wants to merge 1 commit intostyled-components:masterfrom
Open
Add a defaultValue fallback for theme#4mergebandit wants to merge 1 commit intostyled-components:masterfrom
mergebandit wants to merge 1 commit intostyled-components:masterfrom
Conversation
There are cases where I want to have a default value applied. I understand that I could do this like so:
```
const getFooterOverrides = theme('mode', {
foo: p => p.theme.colors.red
})
const Footer = styled.footer`
color: blue;
color: ${getFooterOverrides}
`
```
I run into problems with this approach when I'm using `attrs`, and have to do things like:
```
const StyledPopUp = styled(PopUpIcon).attrs({
color: p => getFooterOverrides(p) || 'blue'
})`
margin-left: 4px;
`
```
It'd be really nice to just have:
```
const getFooterOverrides = theme('mode', {
defaultValue: 'blue'
foo: p => p.theme.colors.red
})
```
|
You can also do export const Container = styled(View)(
props => ({
backgroundColor: colors.principal(props),
textColor: colors.principalText(props),
}),
);and in colors file export default {
principal: props => theme('mode', { 'light': '#039BE5', 'dark: '#000420'})(props),
principalText: props => theme('mode', { 'light': '#000000', 'dark: '#000000'})(props),
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are cases where I want to have a default value applied. I understand that I could do this like so:
I run into problems with this approach when I'm using
attrs, and have to do things like:It'd be really nice to just have:
And then simply say ...