Use setup-gradle w/ cache-provider: basic to use more permissive MIT …#8256
Use setup-gradle w/ cache-provider: basic to use more permissive MIT …#8256jack-berg wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8256 +/- ##
============================================
- Coverage 90.32% 90.31% -0.01%
Complexity 7651 7651
============================================
Files 842 842
Lines 23075 23075
Branches 2312 2312
============================================
- Hits 20842 20841 -1
- Misses 1514 1516 +2
+ Partials 719 718 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
what's the benefit given that we are already agreeing to the same terms of use in CI? opentelemetry-java/settings.gradle.kts Lines 91 to 93 in 207c861 |
Reading the blog post and related comments, I didn't come away with a lot of confidence of what we were actually signing up for. I think your pointing out that since we already agree to the TOS, limiting the cache to the basic version is moot. But what I don't know is if the resolved termsOfUse is the same whether we use the basic cache provider or the more advanced one with a restrictive license. Assuming that the resolved TOU are dependent on which cache provider is used, the idea here is to be conservative at least until the dust settles and it becomes more clear if the more restrictive license is problematic. Need to dig into whether the TOU is dependent on which cache provider is used. |
|
Check out this: https://github.com/gradle/actions/blame/11d4d83c63a6ce61b32d8a9c4faddbdb04fe9917/DISTRIBUTION.md#L48 My read is that this means the TOU do depend on which cache provider is used. |
…license