Skip to content

Use setup-gradle w/ cache-provider: basic to use more permissive MIT …#8256

Open
jack-berg wants to merge 1 commit intoopen-telemetry:mainfrom
jack-berg:basic-cache-provider
Open

Use setup-gradle w/ cache-provider: basic to use more permissive MIT …#8256
jack-berg wants to merge 1 commit intoopen-telemetry:mainfrom
jack-berg:basic-cache-provider

Conversation

@jack-berg
Copy link
Copy Markdown
Member

…license

@jack-berg jack-berg requested a review from a team as a code owner April 6, 2026 19:28
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.31%. Comparing base (207c861) to head (4451c0e).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #8256      +/-   ##
============================================
- Coverage     90.32%   90.31%   -0.01%     
  Complexity     7651     7651              
============================================
  Files           842      842              
  Lines         23075    23075              
  Branches       2312     2312              
============================================
- Hits          20842    20841       -1     
- Misses         1514     1516       +2     
+ Partials        719      718       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@trask
Copy link
Copy Markdown
Member

trask commented Apr 6, 2026

what's the benefit given that we are already agreeing to the same terms of use in CI?

} else if (isCI) {
termsOfUseUrl = "https://gradle.com/help/legal-terms-of-use"
termsOfUseAgree = "yes"

@jack-berg
Copy link
Copy Markdown
Member Author

what's the benefit given that we are already agreeing to the same terms of use in CI?

Reading the blog post and related comments, I didn't come away with a lot of confidence of what we were actually signing up for.

I think your pointing out that since we already agree to the TOS, limiting the cache to the basic version is moot. But what I don't know is if the resolved termsOfUse is the same whether we use the basic cache provider or the more advanced one with a restrictive license.

Assuming that the resolved TOU are dependent on which cache provider is used, the idea here is to be conservative at least until the dust settles and it becomes more clear if the more restrictive license is problematic.

Need to dig into whether the TOU is dependent on which cache provider is used.

@jack-berg
Copy link
Copy Markdown
Member Author

Check out this: https://github.com/gradle/actions/blame/11d4d83c63a6ce61b32d8a9c4faddbdb04fe9917/DISTRIBUTION.md#L48

My read is that this means the TOU do depend on which cache provider is used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants