[partial][draft][in-progress] migrating unit tests#928
Draft
JordanMaples wants to merge 5 commits intomainfrom
Draft
[partial][draft][in-progress] migrating unit tests#928JordanMaples wants to merge 5 commits intomainfrom
JordanMaples wants to merge 5 commits intomainfrom
Conversation
2a56fc4 to
5a59f22
Compare
5a59f22 to
5655eea
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #928 +/- ##
==========================================
- Coverage 89.38% 89.37% -0.02%
==========================================
Files 447 448 +1
Lines 84299 84265 -34
==========================================
- Hits 75350 75308 -42
- Misses 8949 8957 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
- Move groundtruth, is_match, assert_top_k_exactly_match, and assert_range_results_exactly_match from diskann-providers/test_utils to diskann/graph/test/search_utils for cross-crate reuse - Migrate test_even_filtering_multihop to diskann as even_filtering_multihop, using test_provider::Provider::grid() - Remove test_multihop_filtering and test_even_filtering_multihop from diskann-providers - Update all consumers in diskann-providers to use shared search_utils Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Add callback_enforces_filtering test to multihop.rs - Expand CallbackMetrics to track total_visits, rejected_count, adjusted_count (matching original) - Remove test_multihop_callback_enforces_filtering, CallbackFilter, and CallbackMetrics from diskann-providers Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Gate is_match, assert_top_k_exactly_match, assert_range_results_exactly_match with #[cfg(test)] in diskann/graph/test/search_utils - Restore search_utils in diskann-providers/test_utils for cross-crate use, re-exporting groundtruth from diskann - Update diskann-providers and diskann-disk imports accordingly - Remove unused imports (Mutex, QueryVisitDecision, Knn) and dead code (test_multihop_search) from diskann-providers - Fix needless_range_loop in multihop.rs - Remove stale duplicate diskann dep in diskann-disk/Cargo.toml Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a first step in the effort to migrate unit tests from diskann_async to diskann #927. If you don't think tests that have been brought over should be moved, they probably shouldn't have been. Please point them out and I'll do my best to put them back where I found them.
I'll update this field as I continue to work on it: