Skip to content

Fix #14661 Regression while handling arrays of function pointers #8436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mptre wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix #14661 Regression while handling arrays of function pointers #8436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/checkunusedvar.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -738,7 +738,9 @@ void CheckUnusedVar::checkFunctionVariableUsage_iterateScopes(const Scope* const
if (type == Variables::none || isPartOfClassStructUnion(i->typeStartToken()))
continue;
const Token* defValTok = i->nameToken()->next();
if (Token::Match(i->nameToken()->previous(), "* %var% ) (")) // function pointer. Jump behind parameter list.
while (defValTok && defValTok->str() == "[")
defValTok = defValTok->link()->next();
if (Token::simpleMatch(defValTok, ") ("))
defValTok = defValTok->linkAt(1)->next();
for (; defValTok; defValTok = defValTok->next()) {
if (defValTok->str() == "[")
Expand Down
7 changes: 7 additions & 0 deletions test/testunusedvar.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7034,6 +7034,13 @@ class TestUnusedVar : public TestFixture {
" funcPtr();\n"
"}");
ASSERT_EQUALS("", errout_str());

// #14661
functionVariableUsage("int main() {\n"
" void (*const funcPtr[])(void) = {x};\n"
" funcPtr[0]();\n"
"}");
ASSERT_EQUALS("", errout_str());
}

void localvarAddr() { // #7747
Expand Down
Loading