Skip to content

Fix #14640 FP uninitvar (address in init list) #8434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrchr-github merged 2 commits into from
Apr 10, 2026
+8 −1
Merged

Fix #14640 FP uninitvar (address in init list) #8434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
814f96f
Update astutils.cpp
chrchr-github Apr 9, 2026
e7dd72c
Update testuninitvar.cpp
chrchr-github Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/astutils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3417,7 +3417,7 @@ static ExprUsage getFunctionUsage(const Token* tok, int indirect, const Settings
// variable init/constructor call?
if (!func && ftok->variable() && ftok == ftok->variable()->nameToken()) {
// STL types or containers don't initialize external variables
if (ftok->variable()->isStlType() || (ftok->variable()->valueType() && ftok->variable()->valueType()->container))
if (indirect == 0 && (ftok->variable()->isStlType() || (ftok->variable()->valueType() && ftok->variable()->valueType()->container)))
return ExprUsage::Used;
// TODO: resolve multiple constructors
if (ftok->variable()->type() && ftok->variable()->type()->classScope) {
Expand Down
7 changes: 7 additions & 0 deletions test/testuninitvar.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7784,6 +7784,13 @@ class TestUninitVar : public TestFixture {
" *s.p = 0;\n"
"}\n");
ASSERT_EQUALS("", errout_str());

valueFlowUninit("void f() {\n"
" int x;\n"
" std::vector<int*> v{ &x };\n"
" *v[0] = 0;\n"
"}\n");
ASSERT_EQUALS("", errout_str());
}

void valueFlowUninitForLoop()
Expand Down
Loading