Skip to content

Fix #14657 report type: handle id suffix better when getting guideline number #8426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wjakobsson merged 4 commits into from
Apr 10, 2026
+11 −2
Merged

Fix #14657 report type: handle id suffix better when getting guideline number #8426

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
308be5e
fix: strip trailing string from Misra C id extraction
Apr 8, 2026
d942bab
fix: strip trailing string from Misra C id extraction
Apr 8, 2026
324ae91
fix-14657
Apr 9, 2026
5fb9f6f
fix-14657
Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions lib/errorlogger.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1080,8 +1080,15 @@
case ReportType::misraC2012:
case ReportType::misraC2023:
case ReportType::misraC2025:
if (errId.rfind("misra-c20", 0) == 0 || errId.rfind("premium-misra-c-20", 0) == 0)
guideline = errId.substr(errId.rfind('-') + 1);
if (errId.rfind("misra-c20", 0) == 0 || errId.rfind("premium-misra-c-20", 0) == 0) {
auto pos1 = errId.find("20") + 5;
if (pos1 >= errId.size())
break;
if (errId.compare(pos1,4,"dir-",0,4) == 0)
pos1 += 4;

Check warning

Code scanning / Cppcheck Premium

Ensure that unsigned integer operations do not wrap Warning

Ensure that unsigned integer operations do not wrap
const auto endpos = errId.find('-', pos1);
guideline = errId.substr(pos1, endpos-pos1);
}
break;
case ReportType::misraCpp2008:
if (errId.rfind("premium-misra-cpp-2008", 0) == 0)
Expand Down
2 changes: 2 additions & 0 deletions test/testerrorlogger.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,6 +361,8 @@ class TestErrorLogger : public TestFixture {
testReportType(ReportType::misraCpp2023, Severity::style, "premium-misra-cpp-2023-dir-0.3.2", "Required", "Dir 0.3.2");
testReportType(ReportType::misraCpp2008, Severity::style, "premium-misra-cpp-2008-3-4-1", "Required", "3-4-1");
testReportType(ReportType::misraC2012, Severity::style, "premium-misra-c-2012-dir-4.6", "Advisory", "Dir 4.6");
testReportType(ReportType::misraC2012, Severity::style, "premium-misra-c-2012-10.4-positive-number", "Required", "10.4");
testReportType(ReportType::misraC2012, Severity::style, "premium-misra-c-2012-10.4", "Required", "10.4");
testReportType(ReportType::misraC2012, Severity::style, "misra-c2012-dir-4.6", "Advisory", "Dir 4.6");
testReportType(ReportType::certC, Severity::error, "resourceLeak", "L3", "FIO42-C");
}
Expand Down
Loading