Skip to content

feat(fetchart): add support for webp files#6511

Merged
snejus merged 2 commits intobeetbox:masterfrom
ShimmerGlass:fetchart-webp
Apr 8, 2026
Merged

feat(fetchart): add support for webp files#6511
snejus merged 2 commits intobeetbox:masterfrom
ShimmerGlass:fetchart-webp

Conversation

@ShimmerGlass
Copy link
Copy Markdown
Contributor

@ShimmerGlass ShimmerGlass commented Apr 8, 2026

Description

Add support for webp images in the fetchart plugin.

To Do

  • Documentation. (If you've added a new command-line flag, for example, find the appropriate page under docs/ to describe it.)
  • Changelog. (Add an entry to docs/changelog.rst to the bottom of one of the lists near the top of the document.)
  • Tests. (Very much encouraged but not strictly required.)

@ShimmerGlass ShimmerGlass requested a review from a team as a code owner April 8, 2026 07:26
@github-actions github-actions bot added the fetchart fetchart plugin label Apr 8, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 8, 2026

Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.26%. Comparing base (2dff447) to head (e49398b).
⚠️ Report is 3 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6511   +/-   ##
=======================================
  Coverage   70.26%   70.26%           
=======================================
  Files         147      147           
  Lines       18752    18752           
  Branches     3059     3059           
=======================================
  Hits        13177    13177           
  Misses       4927     4927           
  Partials      648      648           
Files with missing lines Coverage Δ
beetsplug/fetchart.py 74.24% <100.00%> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@snejus snejus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just needs a note in the changelog. Could you double-check whether any docs need updating, also taking into account your PR from yesterday?

@ShimmerGlass
Copy link
Copy Markdown
Contributor Author

@snejus looking at the changelog update from yesterday's PR, I think this should be moved to bug fixes. do you agree?
- :doc:`plugins/fetchart`: Error when a configured source does not exist or sources configuration is empty.

@snejus
Copy link
Copy Markdown
Member

snejus commented Apr 8, 2026

@snejus looking at the changelog update from yesterday's PR, I think this should be moved to bug fixes. do you agree? - :doc:`plugins/fetchart`: Error when a configured source does not exist or sources configuration is empty.

Looks good. Did you check fetchart plugin documentation whether any of it needs updating?

@ShimmerGlass
Copy link
Copy Markdown
Contributor Author

yup, I made a small change to the fetchart doc

Copy link
Copy Markdown
Member

@snejus snejus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@snejus snejus enabled auto-merge April 8, 2026 17:36
@snejus snejus merged commit 4e08403 into beetbox:master Apr 8, 2026
22 of 23 checks passed
@ShimmerGlass ShimmerGlass deleted the fetchart-webp branch April 8, 2026 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fetchart fetchart plugin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants