Skip to content

SONARJAVA-6233 Add slf4j-simple to capture logs from the orchestrator#5551

Merged
tomasz-tylenda-sonarsource merged 2 commits intomasterfrom
tt/orchestrator
Apr 10, 2026
Merged

SONARJAVA-6233 Add slf4j-simple to capture logs from the orchestrator#5551
tomasz-tylenda-sonarsource merged 2 commits intomasterfrom
tt/orchestrator

Conversation

@tomasz-tylenda-sonarsource
Copy link
Copy Markdown
Contributor

@tomasz-tylenda-sonarsource tomasz-tylenda-sonarsource commented Apr 2, 2026

Tested:

  • verified that the log of ruling QA does not grow excessively: ubuntu without-sonarqube: 12697 -> 12882 lines.
  • verfied that the log of plugin QA containst orchestrator logs, for example, "com.sonar.orchestrator.locator.MavenLocator - Found (...)". Since it is polluted with debug statements anyway (they are neede for telemetry) I did not check the size.

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title Temporary for testing SONARJAVA-6233 Temporary for testing Apr 2, 2026
@hashicorp-vault-sonar-prod
Copy link
Copy Markdown
Contributor

hashicorp-vault-sonar-prod bot commented Apr 2, 2026

SONARJAVA-6233

@tomasz-tylenda-sonarsource tomasz-tylenda-sonarsource changed the title SONARJAVA-6233 Temporary for testing SONARJAVA-6233 Add slf4j-simple to capture logs from the orchestrator Apr 2, 2026
@tomasz-tylenda-sonarsource tomasz-tylenda-sonarsource marked this pull request as ready for review April 7, 2026 12:26
@sonar-review-alpha
Copy link
Copy Markdown

sonar-review-alpha bot commented Apr 7, 2026

Summary

Adds slf4j-simple binding to test dependencies to enable SLF4J logging from the orchestrator. Without an SLF4J implementation, the library defaults to a no-op logger that silently discards all logs. This change provides actual console output during test runs while keeping log volume reasonable (verified minimal growth in QA logs).

What reviewers should know

What changed: Added slf4j-simple to its/plugin/tests and its/ruling test modules, and extracted the SLF4J version to a parent POM property for consistency.

Why this matters: Tests were missing orchestrator logs entirely because SLF4J had no implementation configured. slf4j-simple is a minimal, lightweight binding suitable for tests.

Review focus: The changes are straightforward dependency additions. Note the version is already managed in the parent POM (1.7.30) for consistency with existing slf4j-api dependency. The author's testing confirms this doesn't cause log spam — the increase is negligible (~185 lines out of ~13k).


  • Generate Walkthrough
  • Generate Diagram

🗣️ Give feedback

sonar-review-alpha[bot]

This comment was marked as outdated.

@sonarqube-next
Copy link
Copy Markdown

sonarqube-next bot commented Apr 7, 2026

Copy link
Copy Markdown

@sonar-review-alpha sonar-review-alpha bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

🗣️ Give feedback

Copy link
Copy Markdown
Contributor

@asya-vorobeva asya-vorobeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tomasz-tylenda-sonarsource tomasz-tylenda-sonarsource merged commit 002e057 into master Apr 10, 2026
18 checks passed
@tomasz-tylenda-sonarsource tomasz-tylenda-sonarsource deleted the tt/orchestrator branch April 10, 2026 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants