Skip to content

Contributing guidelines: Reviewer credit assignment for substantial code review contributions #1319

@florianl

Description

@florianl

This is a follow up to #1311 and #1296 (comment), and the request #1311 (comment).

The CONTRIBUTING.md section How to Address Review Feedback establishes a clear preference for using GitHub's built-in suggestion feature. It explicitly discourages authors from manually reimplementing review suggestions in separate commits, citing three reasons:

  1. Additional burden on reviewers to verify the reimplementation
  2. Increased probability of bugs
  3. Loss of reviewer credit (GitHub's suggestion acceptance mechanism auto-attributes the reviewer)

This policy inadvertently incentivizes reviewers to use GitHub suggestions for all feedback. However, not all review feedback is suitable for suggestions—particularly:

  • Structural or architectural guidance that requires discussion and iterative refinement
  • Complex refactoring that spans multiple files and functions
  • Feedback that needs context or explanation beyond what a suggestion can capture
  • Relevant changes outside of the scope where GitHub allows to make suggestions

When reviewers provide substantial guidance through comments instead, the current policy offers no mechanism to credit their contribution.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions